Re: [PATCH v2] difftool: always honor fatal error exit codes

2016-08-15 Thread Junio C Hamano
John Keeping writes: > Here's what that looks like. Sounds good. It feels a bit funny to see that new mentions of $status are unquoted (which is totally valid because we know it has $? that cannot be anything other than a short decimal integer), while the one in the post-context quotes it, but

[PATCH v2] difftool: always honor fatal error exit codes

2016-08-15 Thread John Keeping
At the moment difftool's "trust exit code" logic always suppresses the exit status of the diff utility we invoke. This is useful because we don't want to exit just because diff returned "1" because the files differ, but it's confusing if the shell returns an error because the selected diff utility