Re: [PATCH v2] difftool: fix dir-diff when file does not exist in working tree

2013-05-17 Thread Junio C Hamano
John Keeping writes: > It can't ever happen because we only call this if the mode is non-zero > in which case the SHA-1 is only null if there are unstaged changes. > > However, I think this revised version is much clearer. Yes, that makes the intention crystal clear. I like it. > > git-diffto

[PATCH v2] difftool: fix dir-diff when file does not exist in working tree

2013-05-17 Thread John Keeping
Commit 02c5631 (difftool --dir-diff: symlink all files matching the working tree, 2013-03-14) does not handle the case where a file that is being compared does not exist in the working tree. Fix this by checking for existence explicitly before running git-hash-object. Reported-by: Kevin Bracey S