Re: [PATCH v2] filter-branch: remove multi-line headers in msg filter

Junio C Hamano venit, vidit, dixit 09.10.2015 19:53: > Michael J Gruber writes: > >>> Set IFS to an empty string for the “read” call, thus disabling the word >>> splitting, which causes $header_line to be set to the non-empty value ' >>> '. This allows the loop to

Re: [PATCH v2] filter-branch: remove multi-line headers in msg filter

Michael J Gruber writes: > Yep, I'm fine with "mini-mentoring", and just to be safe, the 7 new > characters in git-filter-branch.sh are (also) > > Signed-off-by: Michael J Gruber > > in case that is needed or preferred. I was wondering if

Re: [PATCH v2] filter-branch: remove multi-line headers in msg filter

James McCoy venit, vidit, dixit 09.10.2015 02:21: > df062010 (filter-branch: avoid passing commit message through sed) > introduced a regression when filtering commits with multi-line headers, > if the header contains a blank line. An example of this is a gpg-signed > commit: > > $ git

Re: [PATCH v2] filter-branch: remove multi-line headers in msg filter

Michael J Gruber writes: >> Set IFS to an empty string for the “read” call, thus disabling the word >> splitting, which causes $header_line to be set to the non-empty value ' >> '. This allows the loop to fully consume the header lines before >> emitting the original,

[PATCH v2] filter-branch: remove multi-line headers in msg filter

df062010 (filter-branch: avoid passing commit message through sed) introduced a regression when filtering commits with multi-line headers, if the header contains a blank line. An example of this is a gpg-signed commit: $ git cat-file commit signed-commit tree