[PATCH v2] git-clean: Display more accurate delete messages

2012-12-17 Thread Zoltan Klinger
(1) Only print out the names of the files and directories that got actually deleted. (2) Show warning message for ignored untracked git repositories Consider the following repo layout: test.git/ |-- tracked_file |-- tracked_dir/ |   |-- some_tracked_file |   |-- some_unt

Re: [PATCH v2] git-clean: Display more accurate delete messages

2012-12-17 Thread Junio C Hamano
Zoltan Klinger writes: > +static void print_filtered(const char *msg, struct string_list *lst) > +{ > + int i; > + char *name; > + char *dir = 0; > + > + sort_string_list(lst); > + > + for (i = 0; i < lst->nr; i++) { > + name = lst->items[i].string; > +

Re: [PATCH v2] git-clean: Display more accurate delete messages

2012-12-18 Thread Zoltan Klinger
Thanks for the feedback. > My reading of the above is that "lst" after sorting is expected to > have something like: > > a/ > a/b/ > a/b/to-be-removed > a/to-be-removed > > and we first show "a/", remember that prefix in "dir", not show > "a/b/" because it matches p

Re: [PATCH v2] git-clean: Display more accurate delete messages

2012-12-18 Thread Junio C Hamano
Zoltan Klinger writes: > Thanks for the feedback. > >> My reading of the above is that "lst" after sorting is expected to >> have something like: >> >> a/ >> a/b/ >> a/b/to-be-removed >> a/to-be-removed >> >> and we first show "a/", remember that prefix in "dir", n