Re: [PATCH v2] git-p4: fix faulty paths for case insensitive systems

2015-08-21 Thread Eric Sunshine
On Fri, Aug 21, 2015 at 4:08 AM, Lars Schneider wrote: > @Luke, Torsten, Eric, Junio: > Thanks for the great feedback. I incorporated everything into > "[PATCH v3] git-p4: fix faulty paths for case insensitive systems”. > Is this the correct way? I have never worked with the email-patch-files > b

Re: [PATCH v2] git-p4: fix faulty paths for case insensitive systems

2015-08-21 Thread Lars Schneider
@Luke, Torsten, Eric, Junio: Thanks for the great feedback. I incorporated everything into "[PATCH v3] git-p4: fix faulty paths for case insensitive systems”. Is this the correct way? I have never worked with the email-patch-files before :-) - Lars On 20 Aug 2015, at 17:55, Junio C Hamano wrot

Re: [PATCH v2] git-p4: fix faulty paths for case insensitive systems

2015-08-20 Thread Torsten Bögershausen
On 2015-08-20 09.16, Lars Schneider wrote: > Thanks for your feedback! See my answers below. >> Identify path names that are different with respect to case sensitivity. > Agreed! > >> >> >>> If there are any then run `p4 dirs` to build up a dictionary >>> containing the "correct" cases for each pa

Re: [PATCH v2] git-p4: fix faulty paths for case insensitive systems

2015-08-20 Thread Junio C Hamano
Lars Schneider writes: >>> + find . | grep TWO/file1.txt && >>> + find . | grep TWO/File2.txt && >>> + find . | grep TWO/file3.txt && >> Not sure about the find | grep here either. > See answers above. These are not very good tests; they will match "OTWO/file1.txto"

Re: [PATCH v2] git-p4: fix faulty paths for case insensitive systems

2015-08-20 Thread Eric Sunshine
On Thu, Aug 20, 2015 at 3:16 AM, Lars Schneider wrote: > On 20 Aug 2015, at 06:59, Torsten Bögershausen wrote: >> On 08/19/2015 10:04 PM, larsxschnei...@gmail.com wrote: >>> From: Lars Schneider >>> +find . | grep two/File2.txt && >> Should we make sure that two/File2.txt exist? >> T

Re: [PATCH v2] git-p4: fix faulty paths for case insensitive systems

2015-08-20 Thread Lars Schneider
Thanks for your feedback! See my answers below. On 20 Aug 2015, at 06:59, Torsten Bögershausen wrote: > Some nit-picking below: > On 08/19/2015 10:04 PM, larsxschnei...@gmail.com wrote: >> From: Lars Schneider >> >> PROBLEM: >> We run P4 servers on Linux and P4 clients on Windows. For an unkno

Re: [PATCH v2] git-p4: fix faulty paths for case insensitive systems

2015-08-19 Thread Torsten Bögershausen
Some nit-picking below: On 08/19/2015 10:04 PM, larsxschnei...@gmail.com wrote: From: Lars Schneider PROBLEM: We run P4 servers on Linux and P4 clients on Windows. For an unknown reason the file path for a number of files in P4 does not match the directory path with respect to case sensitivity.

[PATCH v2] git-p4: fix faulty paths for case insensitive systems

2015-08-19 Thread larsxschneider
From: Lars Schneider PROBLEM: We run P4 servers on Linux and P4 clients on Windows. For an unknown reason the file path for a number of files in P4 does not match the directory path with respect to case sensitivity. E.g. `p4 files` might return //depot/path/to/file1 //depot/PATH/to/file2 If you

[PATCH v2] git-p4: fix faulty paths for case insensitive systems

2015-08-19 Thread larsxschneider
From: Lars Schneider Hi, as discussed with Luke in "[PATCH] git-p4: fix faulty paths for case insensitive systems" I added a test case for my path fix. I also changed the trigger for the fix to the command line parameter "--fix-paths". Cheers, Lars Lars Schneider (1): git-p4: fix faulty path