Re: [PATCH v2] gitk: make pointer selection visible in highlighted lines

2013-12-02 Thread Stefan Haller
Paul Mackerras pau...@samba.org wrote: On Thu, Nov 28, 2013 at 11:20:18PM +0200, Max Kirillov wrote: Custom tags have higher priority than `sel`, and when they define their own background, it makes selection invisible. Especially inconvenient for `filesep` (to select filenames), but also

Re: [PATCH v2] gitk: make pointer selection visible in highlighted lines

2013-12-02 Thread Max Kirillov
On Mon, Dec 02, 2013 at 11:04:09AM +0100, Stefan Haller wrote: I don't think that not selecting the search hint is an option: the selection is used to keep track of where to search next. To mark the next found position, should a 0-length selection be enough? I will try to experiment with it.

Re: [PATCH v2] gitk: make pointer selection visible in highlighted lines

2013-12-01 Thread Paul Mackerras
On Thu, Nov 28, 2013 at 11:20:18PM +0200, Max Kirillov wrote: Custom tags have higher priority than `sel`, and when they define their own background, it makes selection invisible. Especially inconvenient for `filesep` (to select filenames), but also affects other tags. Use `tag raise` to fix

[PATCH v2] gitk: make pointer selection visible in highlighted lines

2013-11-28 Thread Max Kirillov
Custom tags have higher priority than `sel`, and when they define their own background, it makes selection invisible. Especially inconvenient for `filesep` (to select filenames), but also affects other tags. Use `tag raise` to fix `sel`'s priority. Also change `omark` tag handling, so that it is