Re: [PATCH v2] merge-recursive: check GIT_MERGE_VERBOSITY only once

Thanks, Eric, indeed it's better to change the commit message. 25.10.2017 14:53, Eric Sunshine wrote: > On Wed, Oct 25, 2017 at 7:39 AM, Andrey Okoshkin > wrote: >> Check 'GIT_MERGE_VERBOSITY' environment variable only once in >> init_merge_options(). >> Consequential

Re: [PATCH v2] merge-recursive: check GIT_MERGE_VERBOSITY only once

On Wed, Oct 25, 2017 at 7:39 AM, Andrey Okoshkin wrote: > Check 'GIT_MERGE_VERBOSITY' environment variable only once in > init_merge_options(). > Consequential call of getenv() may return NULL pointer. It would be particularly nice to have a more detailed explanation in

[PATCH v2] merge-recursive: check GIT_MERGE_VERBOSITY only once

Check 'GIT_MERGE_VERBOSITY' environment variable only once in init_merge_options(). Consequential call of getenv() may return NULL pointer. However the stored pointer to the obtained getenv() result may be invalidated by some other getenv() call as getenv() is not thread-safe. Signed-off-by: