Re: [PATCH v2] name_rev: add support for --cherry-picks

2018-07-27 Thread Junio C Hamano
Tejun Heo writes: > ... After all, calling the program twice isn't all that > difficult. As long as we all agree on that, I think we can move forward. Because I think this ... >> ... But it feels like >> "reverse-map the cherry-picks" is orthogonal to the idea of name-rev. ... is a better way

Re: [PATCH v2] name_rev: add support for --cherry-picks

2018-07-27 Thread Tejun Heo
Hello, Jeff. On Fri, Jul 27, 2018 at 4:47 AM Jeff King wrote: > - the set of names might be distinct from the set of commits you'd want >to traverse. For instance, you might want to use "name-rev --tags", >but find cherry-picks even on untagged branches (e.g., "--all"). Hmm... maybe

Re: [PATCH v2] name_rev: add support for --cherry-picks

2018-07-27 Thread Jeff King
On Thu, Jul 26, 2018 at 12:01:34PM -0700, Junio C Hamano wrote: > Tejun Heo writes: > > > I should have explained the use case better. > > No, you did not need to. I was not saying the feature is not useful. > I was only saying that "explain where in the history X sits" command > (i.e.

Re: [PATCH v2] name_rev: add support for --cherry-picks

2018-07-26 Thread Junio C Hamano
Tejun Heo writes: > I should have explained the use case better. No, you did not need to. I was not saying the feature is not useful. I was only saying that "explain where in the history X sits" command (i.e. "name-rev X" and "describe X") did not look like a good place to have that feature.

Re: [PATCH v2] name_rev: add support for --cherry-picks

2018-07-26 Thread Tejun Heo
Hello, Junio. On Thu, Jul 26, 2018 at 08:12:45AM -0700, Junio C Hamano wrote: > Tejun Heo writes: > > > From a6a88c3da252d69547ac8b463098fc4f4c03f322 Mon Sep 17 00:00:00 2001 > > From: Tejun Heo > > Date: Thu, 26 Jul 2018 04:14:52 -0700 > > Subject: [PATCH] name_rev: add support for

Re: [PATCH v2] name_rev: add support for --cherry-picks

2018-07-26 Thread Junio C Hamano
Tejun Heo writes: > From a6a88c3da252d69547ac8b463098fc4f4c03f322 Mon Sep 17 00:00:00 2001 > From: Tejun Heo > Date: Thu, 26 Jul 2018 04:14:52 -0700 > Subject: [PATCH] name_rev: add support for --cherry-picks The above belongs to the mail header, not the body. > It's often useful to track

[PATCH v2] name_rev: add support for --cherry-picks

2018-07-26 Thread Tejun Heo
>From a6a88c3da252d69547ac8b463098fc4f4c03f322 Mon Sep 17 00:00:00 2001 From: Tejun Heo Date: Thu, 26 Jul 2018 04:14:52 -0700 Subject: [PATCH] name_rev: add support for --cherry-picks It's often useful to track cherry-picks of a given commit. Add --cherry-picks support to git-name-rev. When