Re: [PATCH v2] packfile: use get_be64() for large offsets

2018-01-19 Thread Junio C Hamano
SZEDER Gábor writes: > Junio, > ... > This patch can't be applied to 'maint' currently at 3013dff86 (Prepare > for 2.15.2, 2017-12-06), as it is in case of 'ds/use-get-be64', > because 'maint' doesn't have get_be64() yet (b2e39d006 (bswap: add 64 > bit endianness helper

Re: [PATCH v2] packfile: use get_be64() for large offsets

2018-01-18 Thread SZEDER Gábor
Junio, > The pack-index version 2 format uses two 4-byte integers in network- > byte order to represent one 8-byte value. The current implementation > has several code clones for stitching these integers together. > > Use get_be64() to create an 8-byte integer from two 4-byte integers >

[PATCH v2] packfile: use get_be64() for large offsets

2018-01-18 Thread Derrick Stolee
The pack-index version 2 format uses two 4-byte integers in network- byte order to represent one 8-byte value. The current implementation has several code clones for stitching these integers together. Use get_be64() to create an 8-byte integer from two 4-byte integers represented this way.