Re: [PATCH v2] rebase -i: add config to abbreviate command-names

Hi Ævar, On Wed, 2017-04-26 at 17:24 +0200, Ævar Arnfjörð Bjarmason wrote: > On Tue, Apr 25, 2017 at 6:43 AM, Liam Beguin wrote: > > Add the 'rebase.abbrevCmd' boolean config option to allow `git rebase -i` > > to abbreviate the command-names in the instruction list. > > >

Re: [PATCH v2] rebase -i: add config to abbreviate command-names

Johannes Schindelin writes: > Hi Junio, > > On Tue, 25 Apr 2017, Junio C Hamano wrote: > >> Running >> >> $ git grep -i -e 'instruction [ls]' -e 'todo l' >> >> lets us count how we call them, and we can see there is only one >> instance of 'instruction list'. >> >>

Re: [PATCH v2] rebase -i: add config to abbreviate command-names

On Tue, Apr 25, 2017 at 6:43 AM, Liam Beguin wrote: > Add the 'rebase.abbrevCmd' boolean config option to allow `git rebase -i` > to abbreviate the command-names in the instruction list. > > This means that `git rebase -i` would print: > p deadbee The oneline of this

Re: [PATCH v2] rebase -i: add config to abbreviate command-names

Hi Liam, On Tue, 25 Apr 2017, liam Beguin wrote: > On Tue, 2017-04-25 at 22:08 +0200, Johannes Schindelin wrote: > > > > On Tue, 25 Apr 2017, Liam Beguin wrote: > > > > > diff --git a/git-rebase--interactive.sh b/git-rebase--interactive.sh > > > index 2c9c0165b5ab..9f3e82b79615 100644 > > >

Re: [PATCH v2] rebase -i: add config to abbreviate command-names

Hi Junio, On Tue, 25 Apr 2017, Junio C Hamano wrote: > Running > > $ git grep -i -e 'instruction [ls]' -e 'todo l' > > lets us count how we call them, and we can see there is only one > instance of 'instruction list'. > > Running the above in v1.7.3 tree shows that it was originally called >

Re: [PATCH v2] rebase -i: add config to abbreviate command-names

Jeff King writes: > I think the words "instruction list" may have come from my suggestion. I > used them because that is the term used in the rebase.instructionFormat > documentation directly above the option you are adding. > > It may be worth a follow-on patch to convert that

Re: [PATCH v2] rebase -i: add config to abbreviate command-names

Jacob Keller writes: > On Mon, Apr 24, 2017 at 11:29 PM, Junio C Hamano wrote: >> Personally I am happy with the beginning of each instruction line >> aligned, so from that point of view, this patch is a mild Meh to me, >> even though I do a fair

Re: [PATCH v2] rebase -i: add config to abbreviate command-names

On Tue, Apr 25, 2017 at 08:13:27PM -0400, liam Beguin wrote: > > > +rebase.abbrevCmd:: > > > + If set to true, `git rebase -i` will abbreviate the command-names in the > > > + instruction list. This means that instead of looking like this, > > > > This is by no means your fault, but it is really

Re: [PATCH v2] rebase -i: add config to abbreviate command-names

Hi Johannes, On Tue, 2017-04-25 at 22:08 +0200, Johannes Schindelin wrote: > Hi Liam, > > On Tue, 25 Apr 2017, Liam Beguin wrote: > > > Add the 'rebase.abbrevCmd' boolean config option to allow `git rebase -i` > > to abbreviate the command-names in the instruction list. > > > > This means

Re: [PATCH v2] rebase -i: add config to abbreviate command-names

Hi Jake, On Tue, 2017-04-25 at 01:29 -0700, Jacob Keller wrote: > On Mon, Apr 24, 2017 at 11:29 PM, Junio C Hamano wrote: > > Personally I am happy with the beginning of each instruction line > > aligned, so from that point of view, this patch is a mild Meh to me, > > even

Re: [PATCH v2] rebase -i: add config to abbreviate command-names

Hi Johannes, On Tue, 2017-04-25 at 23:23 +0200, Johannes Schindelin wrote: > Hi Andreas, > > On Tue, 25 Apr 2017, Andreas Schwab wrote: > > > On Apr 25 2017, Liam Beguin wrote: > > > > > diff --git a/Documentation/config.txt b/Documentation/config.txt > > > index

Re: [PATCH v2] rebase -i: add config to abbreviate command-names

Hi Andreas, On Tue, 25 Apr 2017, Andreas Schwab wrote: > On Apr 25 2017, Liam Beguin wrote: > > > diff --git a/Documentation/config.txt b/Documentation/config.txt > > index 475e874d5155..8b1877f2df91 100644 > > --- a/Documentation/config.txt > > +++

Re: [PATCH v2] rebase -i: add config to abbreviate command-names

Hi Liam, On Tue, 25 Apr 2017, Liam Beguin wrote: > Add the 'rebase.abbrevCmd' boolean config option to allow `git rebase -i` > to abbreviate the command-names in the instruction list. > > This means that `git rebase -i` would print: > p deadbee The oneline of this commit > ... > >

Re: [PATCH v2] rebase -i: add config to abbreviate command-names

On Tue, Apr 25, 2017 at 5:57 AM, Andreas Schwab wrote: > On Apr 25 2017, Liam Beguin wrote: > >> Add the 'rebase.abbrevCmd' boolean config option to allow `git rebase -i` >> to abbreviate the command-names in the instruction list. >> >> This means

Re: [PATCH v2] rebase -i: add config to abbreviate command-names

From: "Liam Beguin" Add the 'rebase.abbrevCmd' boolean config option to allow `git rebase -i` to abbreviate the command-names in the instruction list. This means that `git rebase -i` would print: p deadbee The oneline of this commit ... instead of: pick deadbee

Re: [PATCH v2] rebase -i: add config to abbreviate command-names

On Apr 25 2017, Liam Beguin wrote: > Add the 'rebase.abbrevCmd' boolean config option to allow `git rebase -i` > to abbreviate the command-names in the instruction list. > > This means that `git rebase -i` would print: > p deadbee The oneline of this commit > ... >

Re: [PATCH v2] rebase -i: add config to abbreviate command-names

On Apr 25 2017, Liam Beguin wrote: > diff --git a/Documentation/config.txt b/Documentation/config.txt > index 475e874d5155..8b1877f2df91 100644 > --- a/Documentation/config.txt > +++ b/Documentation/config.txt > @@ -2614,6 +2614,25 @@ rebase.instructionFormat:: > the

Re: [PATCH v2] rebase -i: add config to abbreviate command-names

On Mon, Apr 24, 2017 at 11:29 PM, Junio C Hamano wrote: > Personally I am happy with the beginning of each instruction line > aligned, so from that point of view, this patch is a mild Meh to me, > even though I do a fair amount of "rebase -i" myself. But obviously > I am not

Re: [PATCH v2] rebase -i: add config to abbreviate command-names

Liam Beguin writes: > Add the 'rebase.abbrevCmd' boolean config option to allow `git rebase -i` > to abbreviate the command-names in the instruction list. > > This means that `git rebase -i` would print: > p deadbee The oneline of this commit > ... > > instead of: >

[PATCH v2] rebase -i: add config to abbreviate command-names

Add the 'rebase.abbrevCmd' boolean config option to allow `git rebase -i` to abbreviate the command-names in the instruction list. This means that `git rebase -i` would print: p deadbee The oneline of this commit ... instead of: pick deadbee The oneline of this commit ... Using

[PATCH v2] rebase -i: add config to abbreviate command-names

Add the 'rebase.abbrevCmd' boolean config option to allow `git rebase -i` to abbreviate the command-names in the instruction list. This means that `git rebase -i` would print: p deadbee The oneline of this commit ... instead of: pick deadbee The oneline of this commit ... Using