Re: [PATCH v2] ref-filter: fallback on alphabetical comparison

2015-10-26 Thread Karthik Nayak
On Mon, Oct 26, 2015 at 6:43 AM, Eric Sunshine wrote: > On Sun, Oct 25, 2015 at 12:29 PM, Karthik Nayak wrote: >> In ref-filter.c the comparison of refs while sorting is handled by >> cmp_ref_sorting() function. When sorting as per numerical values

Re: [PATCH v2] ref-filter: fallback on alphabetical comparison

2015-10-25 Thread Eric Sunshine
On Sun, Oct 25, 2015 at 12:29 PM, Karthik Nayak wrote: > In ref-filter.c the comparison of refs while sorting is handled by > cmp_ref_sorting() function. When sorting as per numerical values > (e.g. --sort=objectsize) there is no fallback comparison when both > refs hold

[PATCH v2] ref-filter: fallback on alphabetical comparison

2015-10-25 Thread Karthik Nayak
In ref-filter.c the comparison of refs while sorting is handled by cmp_ref_sorting() function. When sorting as per numerical values (e.g. --sort=objectsize) there is no fallback comparison when both refs hold the same value. This can cause unexpected results (i.e. the order of listting refs with