[PATCH v2] repack.c: Use move_temp_to_file() instead of rename()

2014-01-27 Thread Torsten Bögershausen
In a1bbc6c0 a shell command "mv -f" was replaced with the rename() function. Use move_temp_to_file() from sha1_file.c instead of rename(). This is in line with the handling of other Git internal tmp files, and calls adjust_shared_perm() Signed-off-by: Torsten Bögershausen --- Thanks for all comm

Re: [PATCH v2] repack.c: Use move_temp_to_file() instead of rename()

2014-01-29 Thread Junio C Hamano
Torsten Bögershausen writes: > In a1bbc6c0 a shell command "mv -f" was replaced with the rename() function. > > Use move_temp_to_file() from sha1_file.c instead of rename(). > This is in line with the handling of other Git internal tmp files, > and calls adjust_shared_perm() > > Signed-off-by: T

Re: [msysGit] Re: [PATCH v2] repack.c: Use move_temp_to_file() instead of rename()

2014-02-02 Thread Torsten Bögershausen
(It seems as if the mail went only to Junio, sorry) On 2014-02-02 16.09, Torsten Bögershausen wrote: > On 2014-01-29 19.17, Junio C Hamano wrote: >> But after a closer inspection, I no longer think that hunk is an >> improvement. These new packfiles were created by pack-objects, >> which finishes