Re: [PATCH v2] run-command.c: print env vars when GIT_TRACE is set

2018-01-12 Thread Duy Nguyen
On Fri, Jan 12, 2018 at 2:27 AM, Junio C Hamano wrote: > I wonder how common it would be to attempt exporting a variable with > the same value, and to attempt unsetting a variable that is not > exported, which might help you reduce the clutter by hiding stuff > that truly do not matter, while keep

Re: [PATCH v2] run-command.c: print env vars when GIT_TRACE is set

2018-01-11 Thread Junio C Hamano
Nguyễn Thái Ngọc Duy writes: > Occasionally submodule code could execute new commands with GIT_DIR set > to some submodule. GIT_TRACE prints just the command line which makes it > hard to tell that it's not really executed on this repository. > > Print modified env variables (compared to parent

Re: [PATCH v2] run-command.c: print env vars when GIT_TRACE is set

2018-01-11 Thread Stefan Beller
On Thu, Jan 11, 2018 at 9:53 AM, Brandon Williams wrote: > On 01/11, Nguyễn Thái Ngọc Duy wrote: >> Occasionally submodule code could execute new commands with GIT_DIR set >> to some submodule. GIT_TRACE prints just the command line which makes it >> hard to tell that it's not really executed on t

Re: [PATCH v2] run-command.c: print env vars when GIT_TRACE is set

2018-01-11 Thread Brandon Williams
On 01/11, Nguyễn Thái Ngọc Duy wrote: > Occasionally submodule code could execute new commands with GIT_DIR set > to some submodule. GIT_TRACE prints just the command line which makes it > hard to tell that it's not really executed on this repository. > > Print modified env variables (compared to

Re: [PATCH v2] run-command.c: print env vars when GIT_TRACE is set

2018-01-11 Thread Duy Nguyen
On Thu, Jan 11, 2018 at 4:47 PM, Nguyễn Thái Ngọc Duy wrote: > Though, Stefan, while i'm not opposed to trace every single setting > in child_process, including variable deletion, cwd and even more, it Another thing I forgot to add, s/ and even more/, redirection&/. At some point I think I was

[PATCH v2] run-command.c: print env vars when GIT_TRACE is set

2018-01-11 Thread Nguyễn Thái Ngọc Duy
Occasionally submodule code could execute new commands with GIT_DIR set to some submodule. GIT_TRACE prints just the command line which makes it hard to tell that it's not really executed on this repository. Print modified env variables (compared to parent environment) in this case. Actually only