Re: [PATCH v2] setup: update error message to be more meaningful

2017-10-04 Thread Kaartic Sivaraam
On Tue, 2017-10-03 at 09:32 +0900, Junio C Hamano wrote: > > As an aside, I wonder if we want to _() the message. It's outside > the scope of this fix, obviously. > I'm surprised it isn't already! I think it should. As an aside, I wanted to know whether we should add 'test_expect_failure's

Re: [PATCH v2] setup: update error message to be more meaningful

2017-10-02 Thread Junio C Hamano
Kaartic Sivaraam writes: > Incorrect case, > > $ git grep "some random regex" -n > fatal: bad flag '-n' used after filename > > The above case is incorrect as "some random regex" isn't a filename > in this case. The command line rule is to have dashed

[PATCH v2] setup: update error message to be more meaningful

2017-10-02 Thread Kaartic Sivaraam
From: Kaartic Sivaraam The error message shown when a flag is found when expecting a filename wasn't clear as it didn't communicate what was wrong using the 'suitable' words in *all* cases. $ git ls-files README.md test-file Correct case,