Re: [PATCH v2] userdiff: funcname and word patterns for sh

2015-03-25 Thread Junio C Hamano
Adrien Schildknecht adrien+...@schischi.me writes: Add regexp based on the Shell Command Language specifications. Because of the lax syntax of sh, some corner cases may not be handled properly. Signed-off-by: Adrien Schildknecht adrien+...@schischi.me --- Is a reroll for this patch coming,

Re: [PATCH v2] userdiff: funcname and word patterns for sh

2015-03-14 Thread Matthieu Moy
On overall, the patch looks good. Some suggestions to improve the tests and a minor nitpick below. Adrien Schildknecht adrien+...@schischi.me writes: +++ b/t/t4034/sh/post @@ -0,0 +1,36 @@ +foo() {lsecho} This part is unchanged here and in the pre file. What does it test? +$((x++))

Re: [PATCH v2] userdiff: funcname and word patterns for sh

2015-03-13 Thread Junio C Hamano
Adrien Schildknecht adrien+...@schischi.me writes: Add regexp based on the Shell Command Language specifications. Because of the lax syntax of sh, some corner cases may not be handled properly. Signed-off-by: Adrien Schildknecht adrien+...@schischi.me --- Those of you who helped in the

[PATCH v2] userdiff: funcname and word patterns for sh

2015-03-09 Thread Adrien Schildknecht
Add regexp based on the Shell Command Language specifications. Because of the lax syntax of sh, some corner cases may not be handled properly. Signed-off-by: Adrien Schildknecht adrien+...@schischi.me --- Documentation/gitattributes.txt | 2 ++ t/t4018-diff-funcname.sh| 1 +