Re: [PATCH v2 0/2] Avoid rewriting "packed-refs" unnecessarily

2017-11-01 Thread Jeff King
On Sat, Oct 28, 2017 at 11:16:00AM +0200, Michael Haggerty wrote: > This reroll make some logically small changes to v1 [1] that are > textually very big: > > * Invert the sense of `is_packed_transaction_noop()` and rename it to > `is_packed_transaction_needed()`. This makes the logic easier to

[PATCH v2 0/2] Avoid rewriting "packed-refs" unnecessarily

2017-10-28 Thread Michael Haggerty
This reroll make some logically small changes to v1 [1] that are textually very big: * Invert the sense of `is_packed_transaction_noop()` and rename it to `is_packed_transaction_needed()`. This makes the logic easier to follow and document. * Add a big comment to that function, describing the