Re: [PATCH v2 0/2] Refactor hash search with fanout table

2018-02-13 Thread Jonathan Tan
On Tue, 13 Feb 2018 11:57:16 -0800 Junio C Hamano wrote: > Jonathan Tan writes: > > > Updates from v1: > > - use uint32_t so that we can operate on packfiles of up to 4G objects > >(this also means that I had to change the signature of the

Re: [PATCH v2 0/2] Refactor hash search with fanout table

2018-02-13 Thread Junio C Hamano
Jonathan Tan writes: > Updates from v1: > - use uint32_t so that we can operate on packfiles of up to 4G objects >(this also means that I had to change the signature of the function) > - don't hide types > > Derrick: you'll need to slightly change your patch to

Re: [PATCH v2 0/2] Refactor hash search with fanout table

2018-02-13 Thread Derrick Stolee
On 2/13/2018 1:39 PM, Jonathan Tan wrote: Updates from v1: - use uint32_t so that we can operate on packfiles of up to 4G objects (this also means that I had to change the signature of the function) I take it "4G objects" means "4 billion objects". The distinction is only important that

[PATCH v2 0/2] Refactor hash search with fanout table

2018-02-13 Thread Jonathan Tan
Updates from v1: - use uint32_t so that we can operate on packfiles of up to 4G objects (this also means that I had to change the signature of the function) - don't hide types Derrick: you'll need to slightly change your patch to use the new API. As for find_abbrev_len_for_pack(), that's a