Re: [PATCH v2 0/2] repack -ad: fix after `fetch --prune` in a shallow repository

2018-07-19 Thread Johannes Schindelin
Hi Peff, On Tue, 17 Jul 2018, Jeff King wrote: > On Tue, Jul 17, 2018 at 03:15:31PM -0400, Jeff King wrote: > > > > - Also trigger `prune_shallow()` when > > > `--unpack-unreachable=` was passed to `git repack`. > > > - No need to trigger `prune_shallow()` when `git repack` was called with >

Re: [PATCH v2 0/2] repack -ad: fix after `fetch --prune` in a shallow repository

2018-07-17 Thread Jeff King
On Tue, Jul 17, 2018 at 03:15:31PM -0400, Jeff King wrote: > > - Also trigger `prune_shallow()` when `--unpack-unreachable=` > > was passed to `git repack`. > > - No need to trigger `prune_shallow()` when `git repack` was called with > > `-k`. > > I think you might have missed the bigger

Re: [PATCH v2 0/2] repack -ad: fix after `fetch --prune` in a shallow repository

2018-07-17 Thread Jeff King
On Tue, Jul 17, 2018 at 06:51:39AM -0700, Johannes Schindelin via GitGitGadget wrote: > Under certain circumstances, commits that were reachable can be made > unreachable, e.g. via `git fetch --prune`. These commits might have > been packed already, in which case `git repack -adlf` will just

[PATCH v2 0/2] repack -ad: fix after `fetch --prune` in a shallow repository

2018-07-17 Thread Johannes Schindelin via GitGitGadget
Under certain circumstances, commits that were reachable can be made unreachable, e.g. via `git fetch --prune`. These commits might have been packed already, in which case `git repack -adlf` will just drop them without giving them the usual grace period before an eventual `git prune` (via `git