Re: [PATCH v2 0/4] UTF8 BOM follow-up

2015-04-20 Thread Junio C Hamano
Karsten Blees karsten.bl...@gmail.com writes: Wouldn't it be better to just strip the BOM on commit, e.g. via a clean filter or pre-commit hook (as suggested in [1])? The users can do whatever they want and if they think having a BOM in these files is a bad idea, I'd encourage them to use

Re: [PATCH v2 0/4] UTF8 BOM follow-up

2015-04-17 Thread Karsten Blees
Am 16.04.2015 um 20:39 schrieb Junio C Hamano: This is on top of the .gitignore can start with UTF8 BOM patch from Carlos. Second try; the first patch is new to clarify the logic in the codeflow after Carlos's patch, and the second one has been adjusted accordingly. Junio C Hamano (4):

Re: [PATCH v2 0/4] UTF8 BOM follow-up

2015-04-16 Thread Jeff King
On Thu, Apr 16, 2015 at 11:39:04AM -0700, Junio C Hamano wrote: This is on top of the .gitignore can start with UTF8 BOM patch from Carlos. Second try; the first patch is new to clarify the logic in the codeflow after Carlos's patch, and the second one has been adjusted accordingly.

[PATCH v2 0/4] UTF8 BOM follow-up

2015-04-16 Thread Junio C Hamano
This is on top of the .gitignore can start with UTF8 BOM patch from Carlos. Second try; the first patch is new to clarify the logic in the codeflow after Carlos's patch, and the second one has been adjusted accordingly. Junio C Hamano (4): add_excludes_from_file: clarify the bom skipping logic