Re: [PATCH v2 0/4] nd/unify-appending-of-s-o-b

2012-11-23 Thread Junio C Hamano
Nguyễn Thái Ngọc Duy writes: > This round cherry-pick and commit only skip S-o-b if the last one is > the same... That sounds sensible. When the user asks us to add sign-off, we should honor it, unless it is known that adding one is absolutely unnecessary, which is "it already exists as the la

[PATCH v2 0/4] nd/unify-appending-of-s-o-b

2012-11-22 Thread Nguyễn Thái Ngọc Duy
This round cherry-pick and commit only skip S-o-b if the last one is the same while format-patch skips it if the same one appears anywhere in S-o-b list. I don't have strong opinion about which way is more correct. Though if we decide to change format-patch behavior, the series may become a bit dif