[PATCH v2 0/6] am state file fix with write_file() clean-up

2015-08-24 Thread Junio C Hamano
git am was recently reimplemented in C. While the implementation was done conservatively and followed the original logic in the scripted version fairly faithfully, the state files it left in the $GIT_DIR/rebase-apply directory were made slightly different by mistake---they lacked the final LF,

Re: [PATCH v2 0/6] am state file fix with write_file() clean-up

2015-08-24 Thread Jeff King
On Mon, Aug 24, 2015 at 01:58:04PM -0700, Junio C Hamano wrote: The workhorse helper function that implements we have this (short) body of text; create a new file that contains it has a fatal parameter, to which 1 was passed by almost all callers, but to casual readers, it was unclear what