Re: [PATCH v2 001/142] check-builtins.sh: use the $( ... ) construct for command substitution

2014-03-26 Thread Matthieu Moy
Elia Pinto gitter.spi...@gmail.com writes: for _f in $(find . -name *.sh) do   sed -i 's@`\(.*\)`@$(\1)@g' ${_f} done What does this do in the case there are multiple ` on the same line? (nested backquotes or multiple `...` `...` on the same line) There are not many instances, and it seems

Re: [PATCH v2 001/142] check-builtins.sh: use the $( ... ) construct for command substitution

2014-03-26 Thread David Kastrup
Junio C Hamano gits...@pobox.com writes: Elia Pinto gitter.spi...@gmail.com writes: The Git CodingGuidelines prefer the $( ... ) construct for command substitution instead of using the back-quotes, or grave accents (`..`). The backquoted form is the historical method for command

Re: [PATCH v2 001/142] check-builtins.sh: use the $( ... ) construct for command substitution

2014-03-26 Thread Matthieu Moy
David Kastrup d...@gnu.org writes: Junio C Hamano gits...@pobox.com writes: Elia Pinto gitter.spi...@gmail.com writes: The Git CodingGuidelines prefer the $( ... ) construct for command substitution instead of using the back-quotes, or grave accents (`..`). The backquoted form is the

[PATCH v2 001/142] check-builtins.sh: use the $( ... ) construct for command substitution

2014-03-25 Thread Elia Pinto
The Git CodingGuidelines prefer the $( ... ) construct for command substitution instead of using the back-quotes, or grave accents (`..`). The backquoted form is the historical method for command substitution, and is supported by POSIX. However, all but the simplest uses become complicated

Re: [PATCH v2 001/142] check-builtins.sh: use the $( ... ) construct for command substitution

2014-03-25 Thread Junio C Hamano
Elia Pinto gitter.spi...@gmail.com writes: The Git CodingGuidelines prefer the $( ... ) construct for command substitution instead of using the back-quotes, or grave accents (`..`). The backquoted form is the historical method for command substitution, and is supported by POSIX. However, all

Re: [PATCH v2 001/142] check-builtins.sh: use the $( ... ) construct for command substitution

2014-03-25 Thread Junio C Hamano
Junio C Hamano gits...@pobox.com writes: Elia Pinto gitter.spi...@gmail.com writes: The Git CodingGuidelines prefer the $( ... ) construct for command substitution instead of using the back-quotes, or grave accents (`..`). The backquoted form is the historical method for command

Re: [PATCH v2 001/142] check-builtins.sh: use the $( ... ) construct for command substitution

2014-03-25 Thread Junio C Hamano
Junio C Hamano gits...@pobox.com writes: I've reworded the above like so: check-builtins.sh: use the $(...) construct for command substitution The Git CodingGuidelines prefer the $(...) construct for command substitution instead of using the backquotes, or grave accents