Jeff King p...@peff.net writes:
I realize that I just bikeshedded on subject lines for half a page, and
part of me wants to go kill myself in shame. But I feel like I see the
technique misapplied often enough that maybe some guidance is merited.
Thanks. What I queued read like these:
$ git
Signed-off-by: Dmitry S. Dolzhenko dmitrys.dolzhe...@yandex.ru
---
builtin/pack-objects.c | 7 +--
1 file changed, 1 insertion(+), 6 deletions(-)
diff --git a/builtin/pack-objects.c b/builtin/pack-objects.c
index c733379..56a6fc8 100644
--- a/builtin/pack-objects.c
+++
On Fri, Feb 28, 2014 at 4:40 PM, Dmitry S. Dolzhenko
dmitrys.dolzhe...@yandex.ru wrote:
Signed-off-by: Dmitry S. Dolzhenko dmitrys.dolzhe...@yandex.ru
---
builtin/pack-objects.c | 7 +--
1 file changed, 1 insertion(+), 6 deletions(-)
diff --git a/builtin/pack-objects.c
On Fri, Feb 28, 2014 at 7:32 PM, Duy Nguyen pclo...@gmail.com wrote:
done_pbase_paths_num++;
If you move this up one line, then you don't have to + 1 in ALLOC_GROW
same comment to a few other patches. The rest of your series looks good.
--
Duy
--
To unsubscribe from this list: send
On 02/28/2014 01:40 PM, Duy Nguyen wrote:
On Fri, Feb 28, 2014 at 7:32 PM, Duy Nguyen pclo...@gmail.com wrote:
done_pbase_paths_num++;
If you move this up one line, then you don't have to + 1 in ALLOC_GROW
same comment to a few other patches. The rest of your series looks good.
On Fri, Feb 28, 2014 at 9:20 PM, Michael Haggerty mhag...@alum.mit.edu wrote:
Duy,
The example in Documentation/technical/api-allocation-growing.txt does
it the same way as Dmitry:
ALLOC_GROW(item, nr + 1, alloc);
item[nr++] = value you like;
The alternative,
nr++;
Michael Haggerty mhag...@alum.mit.edu writes:
So my vote is that the patches are OK the way Dmitry wrote them (mind, I
have only read through 05/11 so far).
Seconded ;-)
By the way, I do not like these long subjects. change is a
redundant word when one sends a patch---as all patches are
On Fri, Feb 28, 2014 at 11:03:19AM -0800, Junio C Hamano wrote:
Michael Haggerty mhag...@alum.mit.edu writes:
So my vote is that the patches are OK the way Dmitry wrote them (mind, I
have only read through 05/11 so far).
Seconded ;-)
By the way, I do not like these long subjects.
8 matches
Mail list logo