Re: [PATCH v2 01/18] cat-file: split expand_atom into 2 functions

2018-01-18 Thread Christian Couder
On Thu, Jan 18, 2018 at 7:22 AM, Оля Тележная wrote: > 2018-01-18 2:04 GMT+03:00 Christian Couder : >> On Wed, Jan 17, 2018 at 10:49 PM, Jeff King wrote: >>> On Tue, Jan 16, 2018 at 10:22:23AM +0300, Оля Тележная wrote: >>>

Re: [PATCH v2 01/18] cat-file: split expand_atom into 2 functions

2018-01-17 Thread Оля Тележная
2018-01-18 2:04 GMT+03:00 Christian Couder : > On Wed, Jan 17, 2018 at 10:49 PM, Jeff King wrote: >> On Tue, Jan 16, 2018 at 10:22:23AM +0300, Оля Тележная wrote: >> >>> >> In other words, I think the endgame is that expand_atom() isn't there at >>> >>

Re: [PATCH v2 01/18] cat-file: split expand_atom into 2 functions

2018-01-17 Thread Christian Couder
On Wed, Jan 17, 2018 at 10:49 PM, Jeff King wrote: > On Tue, Jan 16, 2018 at 10:22:23AM +0300, Оля Тележная wrote: > >> >> In other words, I think the endgame is that expand_atom() isn't there at >> >> all, and we're calling the equivalent of format_ref_item() for each >> >> object

Re: [PATCH v2 01/18] cat-file: split expand_atom into 2 functions

2018-01-17 Thread Jeff King
On Tue, Jan 16, 2018 at 10:22:23AM +0300, Оля Тележная wrote: > >> In other words, I think the endgame is that expand_atom() isn't there at > >> all, and we're calling the equivalent of format_ref_item() for each > >> object (except that in a unified formatting world, it probably doesn't > >>

Re: [PATCH v2 01/18] cat-file: split expand_atom into 2 functions

2018-01-15 Thread Оля Тележная
2018-01-16 1:09 GMT+03:00 Jeff King : > On Mon, Jan 15, 2018 at 04:33:35PM -0500, Jeff King wrote: > >> That works, but I don't think it's where we want to end up in the long >> run. I absolutely agree, I want to merge current edits and then continue migrating process. And

Re: [PATCH v2 01/18] cat-file: split expand_atom into 2 functions

2018-01-15 Thread Jeff King
On Mon, Jan 15, 2018 at 04:33:35PM -0500, Jeff King wrote: > That works, but I don't think it's where we want to end up in the long > run. Because: > > 1. We still have the set of formats duplicated between expand_atom() > and the "preparation" step. It's just that the preparation is now

Re: [PATCH v2 01/18] cat-file: split expand_atom into 2 functions

2018-01-15 Thread Jeff King
On Wed, Jan 10, 2018 at 09:36:41AM +, Olga Telezhnaya wrote: > Split expand_atom function into 2 different functions, > expand_atom_into_fields prepares variable for further filling, > (new) expand_atom creates resulting string. > Need that for further reusing of formatting logic from

[PATCH v2 01/18] cat-file: split expand_atom into 2 functions

2018-01-10 Thread Olga Telezhnaya
Split expand_atom function into 2 different functions, expand_atom_into_fields prepares variable for further filling, (new) expand_atom creates resulting string. Need that for further reusing of formatting logic from ref-filter. Signed-off-by: Olga Telezhnaia