Re: [PATCH v2 01/94] builtin/apply: make gitdiff_verify_name() return void

2016-05-12 Thread Junio C Hamano
Christian Couder writes: > As the value returned by gitdiff_verify_name() is put into the > same variable that is passed as a parameter to this function, > it is simpler to pass the address of the variable and have > gitdiff_verify_name() change the variable itself. >

[PATCH v2 01/94] builtin/apply: make gitdiff_verify_name() return void

2016-05-11 Thread Christian Couder
As the value returned by gitdiff_verify_name() is put into the same variable that is passed as a parameter to this function, it is simpler to pass the address of the variable and have gitdiff_verify_name() change the variable itself. This also makes it possible to later have this function return