Re: [PATCH v2 02/11] tests: at-combinations: check ref names directly

2013-05-08 Thread Felipe Contreras
On Wed, May 8, 2013 at 12:55 AM, Junio C Hamano gits...@pobox.com wrote: Felipe Contreras felipe.contre...@gmail.com writes: Some committishes might point to the same commit, but through a different ref, that's why it's better to check directly for the ref, rather than the commit message.

[PATCH v2 02/11] tests: at-combinations: check ref names directly

2013-05-07 Thread Felipe Contreras
Some committishes might point to the same commit, but through a different ref, that's why it's better to check directly for the ref, rather than the commit message. We can do that by calling rev-parse --symbolic-full-name, and to differentiate the old from the new behavior we add an extra

Re: [PATCH v2 02/11] tests: at-combinations: check ref names directly

2013-05-07 Thread Junio C Hamano
Felipe Contreras felipe.contre...@gmail.com writes: Some committishes might point to the same commit, but through a different ref, that's why it's better to check directly for the ref, rather than the commit message. We can do that by calling rev-parse --symbolic-full-name, and to