Re: [PATCH v2 02/94] builtin/apply: avoid parameter shadowing 'p_value' global

2016-05-12 Thread Junio C Hamano
Christian Couder writes: > Let's just rename the global 'state_p_value' as it will become > 'state->p_value' in a following patch. > > This also avoid errors when compiling with -Wshadow and makes > it safer to later move global variables into a "state" struct. Looks correctly done (I looked at

[PATCH v2 02/94] builtin/apply: avoid parameter shadowing 'p_value' global

2016-05-11 Thread Christian Couder
Let's just rename the global 'state_p_value' as it will become 'state->p_value' in a following patch. This also avoid errors when compiling with -Wshadow and makes it safer to later move global variables into a "state" struct. Helped-by: Nguyễn Thái Ngọc Duy Reviewed-by: Stefan Beller Signed-of