Re: [PATCH v2 03/11] tests: at-combinations: improve nonsense()

2013-05-08 Thread Felipe Contreras
On Wed, May 8, 2013 at 12:55 AM, Junio C Hamano gits...@pobox.com wrote: Felipe Contreras felipe.contre...@gmail.com writes: In some circumstances 'git log' might fail, but not because the @ parsing failed. For example: 'git rev-parse' might succeed and return a bad object, and then 'git log'

[PATCH v2 03/11] tests: at-combinations: improve nonsense()

2013-05-07 Thread Felipe Contreras
In some circumstances 'git log' might fail, but not because the @ parsing failed. For example: 'git rev-parse' might succeed and return a bad object, and then 'git log' would fail. The layer we want to test is revision parsing, so let's test that directly. Signed-off-by: Ramkumar Ramachandra

Re: [PATCH v2 03/11] tests: at-combinations: improve nonsense()

2013-05-07 Thread Junio C Hamano
Felipe Contreras felipe.contre...@gmail.com writes: In some circumstances 'git log' might fail, but not because the @ parsing failed. For example: 'git rev-parse' might succeed and return a bad object, and then 'git log' would fail. The layer we want to test is revision parsing, so let's