Re: [PATCH v2 04/14] describe: use commit-slab for commit names instead of commit->util

2018-05-13 Thread Junio C Hamano
Nguyễn Thái Ngọc Duy writes: > + slot = commit_names_peek(_names, c); > + n = slot ? *slot : NULL; Seeing this and the helper in the previous step makes me wonder if we also want a "peek-and-then-peel" variant that encapsulates this pattern. We'll

[PATCH v2 04/14] describe: use commit-slab for commit names instead of commit->util

2018-05-12 Thread Nguyễn Thái Ngọc Duy
It's done so that commit->util can be removed. See more explanation in the commit that removes commit->util. Signed-off-by: Nguyễn Thái Ngọc Duy --- builtin/describe.c | 16 +--- 1 file changed, 13 insertions(+), 3 deletions(-) diff --git a/builtin/describe.c