Re: [PATCH v2 04/24] refs: convert update_ref and refs_update_ref to use struct object_id

2017-10-12 Thread brian m. carlson
On Wed, Oct 11, 2017 at 08:33:46AM +0200, Michael Haggerty wrote: > On 10/09/2017 03:11 AM, brian m. carlson wrote: > > diff --git a/refs.c b/refs.c > > index 0a5b68d6fb..51942df7b3 100644 > > --- a/refs.c > > +++ b/refs.c > > [...] > > @@ -1003,12 +995,12 @@ int refs_update_ref(struct ref_store

Re: [PATCH v2 04/24] refs: convert update_ref and refs_update_ref to use struct object_id

2017-10-11 Thread Michael Haggerty
On 10/09/2017 03:11 AM, brian m. carlson wrote: > Convert update_ref, refs_update_ref, and write_pseudoref to use struct > object_id. Update the existing callers as well. Remove update_ref_oid, > as it is no longer needed. > > Signed-off-by: brian m. carlson > ---

Re: [PATCH v2 04/24] refs: convert update_ref and refs_update_ref to use struct object_id

2017-10-09 Thread Jonathan Nieder
brian m. carlson wrote: > Convert update_ref, refs_update_ref, and write_pseudoref to use struct > object_id. Update the existing callers as well. Remove update_ref_oid, > as it is no longer needed. > > Signed-off-by: brian m. carlson > --- I'm very happy to see

[PATCH v2 04/24] refs: convert update_ref and refs_update_ref to use struct object_id

2017-10-08 Thread brian m. carlson
Convert update_ref, refs_update_ref, and write_pseudoref to use struct object_id. Update the existing callers as well. Remove update_ref_oid, as it is no longer needed. Signed-off-by: brian m. carlson --- bisect.c | 5 +++-- builtin/am.c