Re: [PATCH v2 06/14] commit-graph: implement git-commit-graph --read

On 2/1/2018 7:23 PM, Jonathan Tan wrote: On Tue, 30 Jan 2018 16:39:35 -0500 Derrick Stolee wrote: Teach git-commit-graph to read commit graph files and summarize their contents. One overall question - is the "read" command meant to be a command used by the end user, or is

Re: [PATCH v2 06/14] commit-graph: implement git-commit-graph --read

On Tue, 30 Jan 2018 16:39:35 -0500 Derrick Stolee wrote: > Teach git-commit-graph to read commit graph files and summarize their > contents. One overall question - is the "read" command meant to be a command used by the end user, or is it here just to test that some aspects

Re: [PATCH v2 06/14] commit-graph: implement git-commit-graph --read

> Teach git-commit-graph to read commit graph files and summarize their > contents. > > Use the --read option to verify the contents of a commit graph file in the > tests. > > Signed-off-by: Derrick Stolee > --- > Documentation/git-commit-graph.txt | 7 ++ >

Re: [PATCH v2 06/14] commit-graph: implement git-commit-graph --read

> +static void free_commit_graph(struct commit_graph **g) > +{ > + if (!g || !*g) > + return; > + > + close_commit_graph(*g); > + > + free(*g); > + *g = NULL; nit: You may want to use FREE_AND_NULL(*g) instead.

[PATCH v2 06/14] commit-graph: implement git-commit-graph --read

Teach git-commit-graph to read commit graph files and summarize their contents. Use the --read option to verify the contents of a commit graph file in the tests. Signed-off-by: Derrick Stolee --- Documentation/git-commit-graph.txt | 7 ++ builtin/commit-graph.c