Re: [PATCH v2 07/14] imap-send.c: inline imap_parse_list() in imap_list()

2013-01-16 Thread Michael Haggerty
On 01/16/2013 04:34 PM, Junio C Hamano wrote: > Michael Haggerty writes: > >> On 01/15/2013 07:51 PM, Matt Kraai wrote: >>> On Tue, Jan 15, 2013 at 09:06:25AM +0100, Michael Haggerty wrote: -static struct imap_list *parse_imap_list(struct imap *imap, char **sp) +static struct imap_list

Re: [PATCH v2 07/14] imap-send.c: inline imap_parse_list() in imap_list()

2013-01-16 Thread Junio C Hamano
Michael Haggerty writes: > On 01/15/2013 07:51 PM, Matt Kraai wrote: >> On Tue, Jan 15, 2013 at 09:06:25AM +0100, Michael Haggerty wrote: >>> -static struct imap_list *parse_imap_list(struct imap *imap, char **sp) >>> +static struct imap_list *parse_list(char **sp) >> >> The commit subject refer

Re: [PATCH v2 07/14] imap-send.c: inline imap_parse_list() in imap_list()

2013-01-16 Thread Michael Haggerty
On 01/15/2013 07:51 PM, Matt Kraai wrote: > On Tue, Jan 15, 2013 at 09:06:25AM +0100, Michael Haggerty wrote: >> -static struct imap_list *parse_imap_list(struct imap *imap, char **sp) >> +static struct imap_list *parse_list(char **sp) > > The commit subject refers to imap_parse_list and imap_list

Re: [PATCH v2 07/14] imap-send.c: inline imap_parse_list() in imap_list()

2013-01-15 Thread Matt Kraai
On Tue, Jan 15, 2013 at 09:06:25AM +0100, Michael Haggerty wrote: > -static struct imap_list *parse_imap_list(struct imap *imap, char **sp) > +static struct imap_list *parse_list(char **sp) The commit subject refers to imap_parse_list and imap_list whereas the code refers to parse_imap_list and pa

[PATCH v2 07/14] imap-send.c: inline imap_parse_list() in imap_list()

2013-01-15 Thread Michael Haggerty
The function is only called from here. Signed-off-by: Michael Haggerty --- imap-send.c | 9 ++--- 1 file changed, 2 insertions(+), 7 deletions(-) diff --git a/imap-send.c b/imap-send.c index f193211..cbbf845 100644 --- a/imap-send.c +++ b/imap-send.c @@ -669,21 +669,16 @@ bail: retu