Re: [PATCH v2 08/24] refs: convert read_ref and read_ref_full to object_id

2017-10-09 Thread Jonathan Nieder
brian m. carlson wrote: > All but two of the call sites already had parameters using the hash nit: "already have", since commit messages use the present for the state of the codebase without the patch applied. > parameter of struct object_id, so convert them to take a pointer to the > struct

[PATCH v2 08/24] refs: convert read_ref and read_ref_full to object_id

2017-10-08 Thread brian m. carlson
All but two of the call sites already had parameters using the hash parameter of struct object_id, so convert them to take a pointer to the struct directly. Also convert refs_read_refs_full, the underlying implementation. Signed-off-by: brian m. carlson ---