Re: [PATCH v2 09/14] bisect.c: use commit-slab for commit weight instead of commit->util

2018-05-13 Thread Junio C Hamano
Nguyễn Thái Ngọc Duy writes: > - p->item->util = &weights[n++]; > + *commit_weight_at(&commit_weight, p->item) = &weights[n++]; Interesting to see that this cleverness was inherited from the original code that used the util field :-). I was wondering why the code was us

[PATCH v2 09/14] bisect.c: use commit-slab for commit weight instead of commit->util

2018-05-12 Thread Nguyễn Thái Ngọc Duy
It's done so that commit->util can be removed. See more explanation in the commit that removes commit->util. Signed-off-by: Nguyễn Thái Ngọc Duy --- bisect.c | 12 +--- 1 file changed, 9 insertions(+), 3 deletions(-) diff --git a/bisect.c b/bisect.c index a579b50884..6de1abd407 100644 -