Re: [PATCH v2 09/53] builtin/rev-parse: convert to struct object_id

2017-05-01 Thread Jonathan Tan
On 04/30/2017 07:29 PM, brian m. carlson wrote: @@ -340,7 +340,7 @@ static int try_parent_shorthands(const char *arg) } if (include_rev) - show_rev(NORMAL, sha1, arg); + show_rev(NORMAL, &oid, arg); for (parents = commit->parents, parent_number

[PATCH v2 09/53] builtin/rev-parse: convert to struct object_id

2017-04-30 Thread brian m. carlson
Some of the functions converted are callers of lookup_commit_reference. However, the changes involved in converting the entire thing are not too large, so we might as well convert it all. Signed-off-by: brian m. carlson --- builtin/rev-parse.c | 56 ++-