Slavica Djukic writes:
>> Yes, but for that you'd need to be checking the resulting commit
>> object that represents the stash entry. It should be created under
>> the substitute identity.
> Would it be correct to check it like this:
>
> git reset &&
> >1 &&
> git add 1
Hi Junio,
On 16-Nov-18 11:12 AM, Junio C Hamano wrote:
Slavica Djukic writes:
+ git var GIT_COMMITTER_IDENT >actual &&
+ test_cmp expected actual &&
I am not sure what you are testing with this step. There is nothing
that changed environment variables or configuration since we
Slavica Djukic writes:
>>> + git var GIT_COMMITTER_IDENT >actual &&
>>> + test_cmp expected actual &&
>> I am not sure what you are testing with this step. There is nothing
>> that changed environment variables or configuration since we ran
>> "git var" above. Why does this test suspect
Hi Junio,
On 16-Nov-18 6:55 AM, Junio C Hamano wrote:
Slavica Djukic writes:
+test_expect_failure 'stash works when user.name and user.email are not set' '
+ git reset &&
+ git var GIT_COMMITTER_IDENT >expected &&
All the other existing test pieces in this file calls the
Junio C Hamano writes:
> Slavica Djukic writes:
>
>> +test_expect_failure 'stash works when user.name and user.email are not set'
>> '
>> +git reset &&
>> +git var GIT_COMMITTER_IDENT >expected &&
> ...
> Anyway, we grab the committer ident we use by default during the
> test with this
Junio C Hamano writes:
> Now we start using use-config-only, so unsetting environment
> variables will cause trouble when Git insists on having an
> explicitly configured identities. Makes sense.
>
>> +(
>> +sane_unset GIT_AUTHOR_NAME &&
>> +sane_unset
Slavica Djukic writes:
> +test_expect_failure 'stash works when user.name and user.email are not set' '
> + git reset &&
> + git var GIT_COMMITTER_IDENT >expected &&
All the other existing test pieces in this file calls the expected
result "expect"; is there a reason why this patch
Hi Slavica,
this looks very good to me. Just one grammar thing:
On Wed, 14 Nov 2018, Slavica Djukic wrote:
> Add test to document that stash fails if user.name and user.email
> are not configured.
> In the later commit, test will be updated to expect success.
In a later commit [...]
Add test to document that stash fails if user.name and user.email
are not configured.
In the later commit, test will be updated to expect success.
Signed-off-by: Slavica Djukic
---
t/t3903-stash.sh | 23 +++
1 file changed, 23 insertions(+)
diff --git a/t/t3903-stash.sh
9 matches
Mail list logo