Re: [PATCH v2 1/2] modernize t7300

Eric Sunshine writes: > Alternately, update test_path_foo() functions to accept multiple > pathnames, or is that too ugly? That actually would have been my first choice, except (1) that path_is_missing has a cruft whose usefulness is dubious, and (2) that "path_exists A B C" and "path_is_missing

Re: [PATCH v2 1/2] modernize t7300

On Mon, Dec 7, 2015 at 4:40 PM, Junio C Hamano wrote: > James writes: >> @@ -46,15 +46,15 @@ test_expect_success 'git clean' ' >> mkdir -p build docs && >> touch a.out src/part3.c docs/manual.txt obj.o build/lib.so && >> git clean && >> - test -f Makefile && >> - test -f

Re: [PATCH v2 1/2] modernize t7300

On Sun, Dec 6, 2015 at 9:58 AM, James wrote: > From: James Rouzier This would be a good place to explain how you are modernizing the test script. Right now, you're just updating to take advantage of test_path_is_foo(), but some other modernizations you could do include: * using '>' rather than

Re: [PATCH v2 1/2] modernize t7300

James writes: > From: James Rouzier > > --- Missing sign-off. > t/t7300-clean.sh | 382 > +++ > 1 file changed, 190 insertions(+), 192 deletions(-) > > diff --git a/t/t7300-clean.sh b/t/t7300-clean.sh > index 86ceb38..d555bb6 100755 > --- a

[PATCH v2 1/2] modernize t7300

From: James Rouzier --- t/t7300-clean.sh | 382 +++ 1 file changed, 190 insertions(+), 192 deletions(-) diff --git a/t/t7300-clean.sh b/t/t7300-clean.sh index 86ceb38..d555bb6 100755 --- a/t/t7300-clean.sh +++ b/t/t7300-clean.sh @@ -28,15 +28,