John Keeping writes:
> On Tue, Jul 22, 2014 at 02:17:13PM -0700, Junio C Hamano wrote:
>> John Keeping writes:
>>
>> > Do you want me to re-roll with this change or can you replace the patch
>> > while applying?
>>
>> I think I had to flip the third one to adjust to the change I
>> suggested t
On Tue, Jul 22, 2014 at 02:17:13PM -0700, Junio C Hamano wrote:
> John Keeping writes:
>
> > Do you want me to re-roll with this change or can you replace the patch
> > while applying?
>
> I think I had to flip the third one to adjust to the change I
> suggested to this; the result will be on 'p
John Keeping writes:
> Makes sense. I don't think I noted the order in the "$cur" case, I just
> put the new one in here so that they were sorted lexicographically.
Unless there is particular reason, consistently using lexicographic
order in all related places is one good way to organize things
On Tue, Jul 22, 2014 at 01:23:25PM -0700, Junio C Hamano wrote:
> John Keeping writes:
>
> > Since the argument to `--recurse-submodules` is mandatory, it does not
> > need to be stuck to the option with `=`.
> >
> > Signed-off-by: John Keeping
> > ---
> > Change since v1:
> > - Fix typo --r
John Keeping writes:
> Since the argument to `--recurse-submodules` is mandatory, it does not
> need to be stuck to the option with `=`.
>
> Signed-off-by: John Keeping
> ---
> Change since v1:
> - Fix typo --recurse{_ => -}submodules
> - Dropped previous patch 1/4 adding ";;" at the end
Since the argument to `--recurse-submodules` is mandatory, it does not
need to be stuck to the option with `=`.
Signed-off-by: John Keeping
---
Change since v1:
- Fix typo --recurse{_ => -}submodules
- Dropped previous patch 1/4 adding ";;" at the end of the "--repo" case
contrib/comple
6 matches
Mail list logo
