Re: [PATCH v2 1/3] connect.c: allow ssh://user@[2001:db8::1]/repo.git

2015-02-22 Thread Junio C Hamano
Torsten Bögershausen tbo...@web.de writes: The ssh:// syntax was added in 2386d65822c91, it accepted ssh://user@2001:db8::1/repo.git, which is now legacy. Please do not quote just a raw object name, but annotate it so that we can more easily tell what the change was about and how far back in

Re: [PATCH v2 1/3] connect.c: allow ssh://user@[2001:db8::1]/repo.git

2015-02-22 Thread Torsten Bögershausen
(Sorry for the spam, a few things need correction already now, and forgot cc: Brian) On 2015-02-21 16.52, Torsten Bögershausen wrote: The ssh:// syntax was added in 2386d65822c91, it accepted ssh://user@2001:db8::1/repo.git, which is now legacy. Over the years the parser was improved to

Re: [PATCH v2 1/3] connect.c: allow ssh://user@[2001:db8::1]/repo.git

2015-02-22 Thread brian m. carlson
On Sun, Feb 22, 2015 at 11:37:40AM -0800, Junio C Hamano wrote: Let me double check if I understand Brian and the above correctly: * The original 2386d658 (Add first cut at git protocol connect logic., 2005-07-13) did not even care that the IPv6 syntax was valid or not, and worse yet, it

[PATCH v2 1/3] connect.c: allow ssh://user@[2001:db8::1]/repo.git

2015-02-21 Thread Torsten Bögershausen
The ssh:// syntax was added in 2386d65822c91, it accepted ssh://user@2001:db8::1/repo.git, which is now legacy. Over the years the parser was improved to support [] and port numbers, but the combination of ssh://user@[2001:db8::1]:222/repo.git did never work. The only only way to use a user