Re: [PATCH v2 1/3] repository: fix repo_read_index with submodules

2017-12-18 Thread Brandon Williams
On 12/18, Thomas Gummerer wrote: > On 12/18, Brandon Williams wrote: > > On 12/17, Thomas Gummerer wrote: > > > repo_read_index calls read_index_from, which takes an path argument for > > > the location of the index file. For the split index however it relies > > > > > on the current working

Re: [PATCH v2 1/3] repository: fix repo_read_index with submodules

2017-12-18 Thread Thomas Gummerer
On 12/18, Brandon Williams wrote: > On 12/17, Thomas Gummerer wrote: > > repo_read_index calls read_index_from, which takes an path argument for > > the location of the index file. For the split index however it relies > > > on the current working directory to construct the path using git_path.

Re: [PATCH v2 1/3] repository: fix repo_read_index with submodules

2017-12-18 Thread Brandon Williams
On 12/17, Thomas Gummerer wrote: > repo_read_index calls read_index_from, which takes an path argument for > the location of the index file. For the split index however it relies > on the current working directory to construct the path using git_path. This line isn't actually true and should

[PATCH v2 1/3] repository: fix repo_read_index with submodules

2017-12-17 Thread Thomas Gummerer
repo_read_index calls read_index_from, which takes an path argument for the location of the index file. For the split index however it relies on the current working directory to construct the path using git_path. repo_read_index calls read_index_from with the full path for the index file,