Re: [PATCH v2 1/4] git-p4: add optional type specifier to gitConfig reader

2015-09-04 Thread Lars Schneider
On 03 Sep 2015, at 23:31, Junio C Hamano wrote: > Lars Schneider writes: > >> In case I agree with a reviewer. What is the more appropriate action? >> A response like the one above or a new role that includes the change >> right away? I don’t want

[PATCH v2 1/4] git-p4: add optional type specifier to gitConfig reader

2015-09-03 Thread larsxschneider
From: Lars Schneider Signed-off-by: Lars Schneider --- git-p4.py | 12 ++-- 1 file changed, 6 insertions(+), 6 deletions(-) diff --git a/git-p4.py b/git-p4.py index 073f87b..c139cab 100755 --- a/git-p4.py +++ b/git-p4.py @@ -604,9

Re: [PATCH v2 1/4] git-p4: add optional type specifier to gitConfig reader

2015-09-03 Thread Lars Schneider
On 03 Sep 2015, at 22:18, Junio C Hamano wrote: > Lars Schneider writes: > >> On 03 Sep 2015, at 21:55, Luke Diamand wrote: >> >>> On 03/09/15 17:35, larsxschnei...@gmail.com wrote: From: Lars Schneider

Re: [PATCH v2 1/4] git-p4: add optional type specifier to gitConfig reader

2015-09-03 Thread Luke Diamand
On 03/09/15 17:35, larsxschnei...@gmail.com wrote: From: Lars Schneider I think this commit may need some explanation! Signed-off-by: Lars Schneider --- git-p4.py | 12 ++-- 1 file changed, 6 insertions(+), 6 deletions(-)

Re: [PATCH v2 1/4] git-p4: add optional type specifier to gitConfig reader

2015-09-03 Thread Junio C Hamano
Lars Schneider writes: > On 03 Sep 2015, at 21:55, Luke Diamand wrote: > >> On 03/09/15 17:35, larsxschnei...@gmail.com wrote: >>> From: Lars Schneider >>> >> >> I think this commit may need some explanation! > > The

Re: [PATCH v2 1/4] git-p4: add optional type specifier to gitConfig reader

2015-09-03 Thread Junio C Hamano
Lars Schneider writes: > In case I agree with a reviewer. What is the more appropriate action? > A response like the one above or a new role that includes the change > right away? I don’t want to spam the list with lots of tiny changes… Responding to review comment

Re: [PATCH v2 1/4] git-p4: add optional type specifier to gitConfig reader

2015-09-03 Thread Lars Schneider
On 03 Sep 2015, at 21:55, Luke Diamand wrote: > On 03/09/15 17:35, larsxschnei...@gmail.com wrote: >> From: Lars Schneider >> > > I think this commit may need some explanation! The functions “gitConfig” and “gitConfigBool” are almost identical.