Re: [PATCH v2 1/4] mergetool--lib: Simplify command expressions

2013-01-29 Thread John Keeping
On Sun, Jan 27, 2013 at 04:52:23PM -0800, David Aguilar wrote: Update variable assignments to always use $(command $arg) in their RHS instead of $(command $arg) as the latter is harder to read. Make get_merge_tool_cmd() simpler by avoiding echo and $(command) substitutions completely.

Re: [PATCH v2 1/4] mergetool--lib: Simplify command expressions

2013-01-29 Thread David Aguilar
On Tue, Jan 29, 2013 at 11:22 AM, John Keeping j...@keeping.me.uk wrote: On Sun, Jan 27, 2013 at 04:52:23PM -0800, David Aguilar wrote: Update variable assignments to always use $(command $arg) in their RHS instead of $(command $arg) as the latter is harder to read. Make get_merge_tool_cmd()

Re: [PATCH v2 1/4] mergetool--lib: Simplify command expressions

2013-01-29 Thread Junio C Hamano
David Aguilar dav...@gmail.com writes: On Tue, Jan 29, 2013 at 11:22 AM, John Keeping j...@keeping.me.uk wrote: On Sun, Jan 27, 2013 at 04:52:23PM -0800, David Aguilar wrote: Update variable assignments to always use $(command $arg) in their RHS instead of $(command $arg) as the latter is

[PATCH v2 1/4] mergetool--lib: Simplify command expressions

2013-01-27 Thread David Aguilar
Update variable assignments to always use $(command $arg) in their RHS instead of $(command $arg) as the latter is harder to read. Make get_merge_tool_cmd() simpler by avoiding echo and $(command) substitutions completely. Signed-off-by: David Aguilar dav...@gmail.com --- I reworded the commit