Re: [PATCH v2 1/4] rev-parse: fix some options when executed from subpath of main tree

2016-05-10 Thread Eric Sunshine
On Fri, May 6, 2016 at 10:13 AM, SZEDER Gábor wrote: > Quoting Mike Rappazzo : >> I'll try to reword this to make it indicate that the value isn't >> always incorrect. > > Not sure I understand your intention about rewording, in particular that > "isn't

Re: [PATCH v2 1/4] rev-parse: fix some options when executed from subpath of main tree

2016-05-06 Thread Junio C Hamano
SZEDER Gábor writes: >> I agree with this, but at one point Junio suggested that it should >> return the relative path[1], > > I wasn't aware of Junio's suggestion. Mike justified his position to change everything to absolute, citing that it is what "rev-parse

Re: [PATCH v2 1/4] rev-parse: fix some options when executed from subpath of main tree

2016-05-06 Thread SZEDER Gábor
Quoting Mike Rappazzo : On Fri, Apr 29, 2016 at 9:50 AM, SZEDER Gábor wrote: Executing `git-rev-parse` with `--git-common-dir`, `--git-path `, or `--shared-index-path` from the root of the main worktree results in a relative path to the git dir. When

Re: [PATCH v2 1/4] rev-parse: fix some options when executed from subpath of main tree

2016-05-06 Thread Mike Rappazzo
On Fri, Apr 29, 2016 at 9:50 AM, SZEDER Gábor wrote: >> Executing `git-rev-parse` with `--git-common-dir`, `--git-path `, >> or `--shared-index-path` from the root of the main worktree results in >> a relative path to the git dir. >> >> When executed from a subdirectory of the

Re: [PATCH v2 1/4] rev-parse: fix some options when executed from subpath of main tree

2016-04-29 Thread SZEDER Gábor
[Resend to list, sorry for the duplicates.] > Executing `git-rev-parse` with `--git-common-dir`, `--git-path `, > or `--shared-index-path` from the root of the main worktree results in > a relative path to the git dir. > > When executed from a subdirectory of the main tree, however, it

[PATCH v2 1/4] rev-parse: fix some options when executed from subpath of main tree

2016-04-22 Thread Michael Rappazzo
Executing `git-rev-parse` with `--git-common-dir`, `--git-path `, or `--shared-index-path` from the root of the main worktree results in a relative path to the git dir. When executed from a subdirectory of the main tree, however, it incorrectly returns a path which starts 'sub/path/.git'. Change