Re: [PATCH v2 1/6] CodingGuidelines: add shell piping guidelines

2018-09-19 Thread Matthew DeVore
On Wed, Sep 19, 2018 at 5:36 AM Eric Sunshine wrote: > > On Tue, Sep 18, 2018 at 10:11 PM Matthew DeVore wrote: > > Yes, it's probably better to add a point about that. Here is the new > > documentation after applying your suggestions: > > > > - If a piped sequence which spans multiple lines,

Re: [PATCH v2 1/6] CodingGuidelines: add shell piping guidelines

2018-09-19 Thread Junio C Hamano
Matthew DeVore writes: > Yes, it's probably better to add a point about that. Here is the new > documentation after applying your suggestions: > > - If a piped sequence which spans multiple lines, put each statement >on a separate line and put pipes on the end of each line, rather >than

Re: [PATCH v2 1/6] CodingGuidelines: add shell piping guidelines

2018-09-19 Thread Eric Sunshine
On Tue, Sep 18, 2018 at 10:11 PM Matthew DeVore wrote: > Yes, it's probably better to add a point about that. Here is the new > documentation after applying your suggestions: > > - If a piped sequence which spans multiple lines, put each statement s/which// >on a separate line and put

Re: [PATCH v2 1/6] CodingGuidelines: add shell piping guidelines

2018-09-18 Thread Matthew DeVore
On Mon, Sep 17, 2018 at 5:16 PM Eric Sunshine wrote: > > On Mon, Sep 17, 2018 at 6:24 PM Matthew DeVore wrote: > > diff --git a/Documentation/CodingGuidelines b/Documentation/CodingGuidelines > > @@ -163,6 +163,35 @@ For shell scripts specifically (not exhaustive): > > + - In a piped sequence

Re: [PATCH v2 1/6] CodingGuidelines: add shell piping guidelines

2018-09-17 Thread Eric Sunshine
On Mon, Sep 17, 2018 at 6:24 PM Matthew DeVore wrote: > diff --git a/Documentation/CodingGuidelines b/Documentation/CodingGuidelines > @@ -163,6 +163,35 @@ For shell scripts specifically (not exhaustive): > + - In a piped sequence which spans multiple lines, put each statement > + on a separate

[PATCH v2 1/6] CodingGuidelines: add shell piping guidelines

2018-09-17 Thread Matthew DeVore
Add two guidelines: - pipe characters should appear at the end of lines, and not cause indentation - pipes should be avoided when they swallow exit codes that can potentially fail --- Documentation/CodingGuidelines | 29 + 1 file changed, 29 insertions(+)