Re: [PATCH v2 1/6] submodule: rename add_sha1_to_array

2017-05-01 Thread Brandon Williams
On 05/01, Stefan Beller wrote: > On Mon, May 1, 2017 at 6:02 PM, Brandon Williams wrote: > > > Change-Id: Ia6d15f34cee4d0dc32f7a475c69f4cb3aa8ce5bf > > Uh? Oops! I forgot to run it through my scrubbing script... > > Maybe another side project for the long todo list: get git-trailers into > s

Re: [PATCH v2 1/6] submodule: rename add_sha1_to_array

2017-05-01 Thread Stefan Beller
On Mon, May 1, 2017 at 6:02 PM, Brandon Williams wrote: > Change-Id: Ia6d15f34cee4d0dc32f7a475c69f4cb3aa8ce5bf Uh? Maybe another side project for the long todo list: get git-trailers into shape, such that it can be configured to yell at you upon formatting the patch or sending email when a give

[PATCH v2 1/6] submodule: rename add_sha1_to_array

2017-05-01 Thread Brandon Williams
Rename 'add_sha1_to_array()' to 'append_oid_to_array()' to more accurately describe what the function does since it handles 'struct object_id' and not sha1 character arrays. Change-Id: Ia6d15f34cee4d0dc32f7a475c69f4cb3aa8ce5bf Signed-off-by: Brandon Williams --- submodule.c | 9 + 1 file