Re: [PATCH v2 1/8] fetch-pack: split up everything_local()

2018-06-14 Thread Brandon Williams
On 06/06, Jonathan Tan wrote: > The function everything_local(), despite its name, also (1) marks > commits as COMPLETE and COMMON_REF and (2) invokes filter_refs() as > important side effects. Extract (1) into its own function > (mark_complete_and_common_ref()) and remove > (2). > > The

[PATCH v2 1/8] fetch-pack: split up everything_local()

2018-06-06 Thread Jonathan Tan
The function everything_local(), despite its name, also (1) marks commits as COMPLETE and COMMON_REF and (2) invokes filter_refs() as important side effects. Extract (1) into its own function (mark_complete_and_common_ref()) and remove (2). The restoring of save_commit_buffer, which was