Re: [PATCH v2 10/25] sequencer: get rid of the subcommand field

2016-09-15 Thread Junio C Hamano
Johannes Schindelin writes: > The subcommands are used exactly once, at the very beginning of > sequencer_pick_revisions(), to determine what to do. This is an > unnecessary level of indirection: we can simply call the correct > function to begin with. So let's do that. Makes sense. And the dif

[PATCH v2 10/25] sequencer: get rid of the subcommand field

2016-09-11 Thread Johannes Schindelin
The subcommands are used exactly once, at the very beginning of sequencer_pick_revisions(), to determine what to do. This is an unnecessary level of indirection: we can simply call the correct function to begin with. So let's do that. While at it, ensure that the subcommands return an error code s