Re: [PATCH v2 11/14] commit: integrate commit graph with commit parsing

2018-02-06 Thread Derrick Stolee
On 2/1/2018 8:51 PM, Jonathan Tan wrote: On Tue, 30 Jan 2018 16:39:40 -0500 Derrick Stolee wrote: +/* global storage */ +struct commit_graph *commit_graph = 0; NULL, not 0. +static int bsearch_graph(struct commit_graph *g, struct object_id *oid, uint32_t *pos) +{ +

Re: [PATCH v2 11/14] commit: integrate commit graph with commit parsing

2018-02-01 Thread Jonathan Tan
On Tue, 30 Jan 2018 16:39:40 -0500 Derrick Stolee wrote: > +/* global storage */ > +struct commit_graph *commit_graph = 0; NULL, not 0. > +static int bsearch_graph(struct commit_graph *g, struct object_id *oid, > uint32_t *pos) > +{ > + uint32_t last, first = 0; > + > +

[PATCH v2 11/14] commit: integrate commit graph with commit parsing

2018-01-30 Thread Derrick Stolee
Teach Git to inspect a commit graph file to supply the contents of a struct commit when calling parse_commit_gently(). This implementation satisfies all post-conditions on the struct commit, including loading parents, the root tree, and the commit date. The only loosely-expected condition is that