Re: [PATCH v2 14/27] connect: request remote refs using v2

2018-01-31 Thread Derrick Stolee
On 1/31/2018 3:10 PM, Eric Sunshine wrote: On Wed, Jan 31, 2018 at 10:22 AM, Derrick Stolee wrote: On 1/25/2018 6:58 PM, Brandon Williams wrote: +static int process_ref_v2(const char *line, struct ref ***list) +{ + int ret = 1; + int i = 0; nit: you set 'i'

Re: [PATCH v2 14/27] connect: request remote refs using v2

2018-01-31 Thread Eric Sunshine
On Wed, Jan 31, 2018 at 10:22 AM, Derrick Stolee wrote: > On 1/25/2018 6:58 PM, Brandon Williams wrote: >> +static int process_ref_v2(const char *line, struct ref ***list) >> +{ >> + int ret = 1; >> + int i = 0; > > nit: you set 'i' here, but first use it in a for

Re: [PATCH v2 14/27] connect: request remote refs using v2

2018-01-31 Thread Derrick Stolee
On 1/25/2018 6:58 PM, Brandon Williams wrote: Teach the client to be able to request a remote's refs using protocol v2. This is done by having a client issue a 'ls-refs' request to a v2 server. Signed-off-by: Brandon Williams --- builtin/upload-pack.c | 10 ++--

[PATCH v2 14/27] connect: request remote refs using v2

2018-01-25 Thread Brandon Williams
Teach the client to be able to request a remote's refs using protocol v2. This is done by having a client issue a 'ls-refs' request to a v2 server. Signed-off-by: Brandon Williams --- builtin/upload-pack.c | 10 ++-- connect.c | 123