Re: [PATCH v2 18/43] refs-be-files.c: add a backend method structure with transaction functions

On 09/29/2015 12:01 AM, David Turner wrote: > From: Ronnie Sahlberg > > Add a ref structure for backend methods. Start by adding method pointers > for the transaction functions. > > Add a function set_refs_backend to switch between backends. The files > based backend is the

Re: [PATCH v2 18/43] refs-be-files.c: add a backend method structure with transaction functions

On Mon, 2015-10-05 at 10:25 -0700, Junio C Hamano wrote: > Michael Haggerty writes: > > >> +/* refs backends */ > >> +typedef struct ref_transaction *(*ref_transaction_begin_fn)(struct strbuf > >> *err); > > > > Hmmm, I thought our convention was to define typedefs for

Re: [PATCH v2 18/43] refs-be-files.c: add a backend method structure with transaction functions

Michael Haggerty writes: >> +/* refs backends */ >> +typedef struct ref_transaction *(*ref_transaction_begin_fn)(struct strbuf >> *err); > > Hmmm, I thought our convention was to define typedefs for functions > themselves, not for the pointer-to-function; e.g., > >

[PATCH v2 18/43] refs-be-files.c: add a backend method structure with transaction functions

From: Ronnie Sahlberg Add a ref structure for backend methods. Start by adding method pointers for the transaction functions. Add a function set_refs_backend to switch between backends. The files based backend is the default. Signed-off-by: Ronnie Sahlberg